Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse UTF-8 strings on Windows #94

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Parse UTF-8 strings on Windows #94

merged 5 commits into from
Mar 3, 2022

Conversation

ateucher
Copy link
Contributor

@ateucher ateucher commented Mar 2, 2022

#90

@ateucher ateucher changed the base branch from issue90 to master March 2, 2022 23:27
@ateucher ateucher marked this pull request as ready for review March 2, 2022 23:36
@ateucher
Copy link
Contributor Author

ateucher commented Mar 2, 2022

@dcooley this appears to be working to fix #90. I added a test that failed before the fix, and now passes with the change (at least locally, we should probably see what the CI says).

@dcooley dcooley merged commit 0550dbe into SymbolixAU:master Mar 3, 2022
@dcooley
Copy link
Collaborator

dcooley commented Mar 3, 2022

Thanks @ateucher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ateucher @dcooley